zig/libvaxis
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Window.printSegments correctly prints all non-trailing whitespace

Browse source 
I'm told it's not unusual in the web world for multiple whitespace
characters to be consumed as a single space. If that is the intention
for `.word` wrap, that's fine with me! If not, this PR correctly
prints all non-trailing whitespace.

I also chose to consume a `\r\n` sequence as intending a single newline,
while all other sequences of `\r` and `\n` should produce multiple newlines.
This commit is contained in:
Rylee Lyman 2024-06-21 15:49:11 -04:00 committed by Tim Culverhouse
parent fcb705adaa
commit 74fb130797
1 changed files with 55 additions and 75 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

100
src/Window.zig
View file

@ -328,56 +328,57 @@ pub fn print(self: Window, segments: []const Segment, opts: PrintOptions) !Print
.word => { .word => {
var col: usize = opts.col_offset; var col: usize = opts.col_offset;
var overflow: bool = false; var overflow: bool = false;
var soft_wrapped: bool = false;
for (segments) |segment| { for (segments) |segment| {
var start: usize = 0; var start: usize = 0;
var tokenizer = std.mem.tokenizeAny(u8, segment.text, "\r\n");
while (tokenizer.peek() != null) {
const returns = segment.text[start..tokenizer.index];
const line = tokenizer.next().?;
start = tokenizer.index;
var i: usize = 0; var i: usize = 0;
while (i < segment.text.len) : (i += 1) { while (i < returns.len) : (i += 1) {
// for (segment.text, 0..) |b, i| { const b = returns[i];
const b = segment.text[i]; if (b == '\r' and i + 1 < returns.len and returns[i + 1] == '\n') {
const end = switch (b) { i += 1;
' ',
'\r',
'\n',
=> i,
else => if (i != segment.text.len - 1) continue else i + 1,
};
const word = segment.text[start..end];
// find the start of the next word
start = while (i + 1 < segment.text.len) : (i += 1) {
if (segment.text[i + 1] == ' ') continue;
break i + 1;
} else i;
const width = self.gwidth(word);
const non_wsp_width: usize = for (word, 0..) |wb, wi| {
if (wb == '\r' or wb == '\n') {
row += 1;
col = 0;
break width -| wi -| 1;
} }
if (wb != ' ') break width - wi;
} else 0;
if (width + col > self.width and non_wsp_width < self.width) {
// wrap
row += 1; row += 1;
col = 0; col = 0;
soft_wrapped = true; }
var iter = std.mem.tokenizeScalar(u8, line, ' ');
var ws_start: usize = 0;
while (iter.peek() != null) {
const whitespace = line[ws_start..iter.index];
const word = iter.next().?;
ws_start = iter.index;
var j: usize = 0;
while (j < whitespace.len) : (j += 1) {
if (opts.commit) self.writeCell(col, row, .{
.char = .{
.grapheme = " ",
.width = 1,
},
.style = segment.style,
.link = segment.link,
});
col += 1;
}
if (col >= self.width) {
col = 0;
row += 1;
}
const width = self.gwidth(word);
if (width + col > self.width and width < self.width) {
row += 1;
col = 0;
} }
if (row >= self.height) { if (row >= self.height) {
overflow = true; overflow = true;
break; break;
} }
// if we are soft wrapped, (col == 0 and row > 0), then trim
// leading spaces var grapheme_iterator = self.screen.unicode.graphemeIterator(word);
const printed_word = if (soft_wrapped) while (grapheme_iterator.next()) |grapheme| {
std.mem.trimLeft(u8, word, " ") const s = grapheme.bytes(word);
else
word;
defer soft_wrapped = false;
var iter = self.screen.unicode.graphemeIterator(printed_word);
while (iter.next()) |grapheme| {
const s = grapheme.bytes(printed_word);
const w = self.gwidth(s); const w = self.gwidth(s);
if (opts.commit) self.writeCell(col, row, .{ if (opts.commit) self.writeCell(col, row, .{
.char = .{ .char = .{
@ -393,27 +394,6 @@ pub fn print(self: Window, segments: []const Segment, opts: PrintOptions) !Print
col = 0; col = 0;
} }
} }
switch (b) {
' ' => {
if (col > 0) {
if (opts.commit) self.writeCell(col, row, .{
.char = .{
.grapheme = " ",
.width = 1,
},
.style = segment.style,
.link = segment.link,
});
col += 1;
}
},
'\r',
'\n',
=> {
col = 0;
row += 1;
},
else => {},
} }
} }
} }