zig/libvaxis
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tty: do not close /dev/tty on macos

Browse source 
Attempting to close /dev/tty may block indefinitely on macos if another
thread is already blocked on a read operation. As there is no practical
use for closing /dev/tty on exit besides unblocking other threads (which
does not work on macos anyway) we can just skip the close call.
This commit is contained in:
CJ van den Berg 2024-05-23 16:19:38 +02:00 committed by Tim Culverhouse
parent 55809160b9
commit 1c11333717
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/Tty.zig
View file

@ -73,7 +73,8 @@ pub fn deinit(self: *Tty) void {
posix.tcsetattr(self.fd, .FLUSH, self.termios) catch |err| { posix.tcsetattr(self.fd, .FLUSH, self.termios) catch |err| {
log.err("couldn't restore terminal: {}", .{err}); log.err("couldn't restore terminal: {}", .{err});
}; };
posix.close(self.fd); if (builtin.os.tag != .macos) // closing /dev/tty may block indefinitely on macos
posix.close(self.fd);
} }
/// stops the run loop /// stops the run loop