kc/helix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove prefix filtering from autocomplete menu (#4578)

Browse source 
PR #4134 switched the autocomplete menu from alphabetical to fuzzy
sorting. This commit removes the still existing filtering by prefix and
should enable full fuzzy sorting of the autocomplete menu.

closes #3084, #1807

Co-authored-by: Blaž Hrastnik <blaz@mxxn.io>
This commit is contained in:
ChrHorn 2022-11-17 02:16:03 +01:00 • committed by GitHub
parent 7483c76222
commit 322e957ea1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
helix-term/src/commands.rs
View file

@ -3950,7 +3950,6 @@ pub fn completion(cx: &mut Context) {
iter.reverse(); iter.reverse();
let offset = iter.take_while(|ch| chars::char_is_word(*ch)).count(); let offset = iter.take_while(|ch| chars::char_is_word(*ch)).count();
let start_offset = cursor.saturating_sub(offset); let start_offset = cursor.saturating_sub(offset);
let prefix = text.slice(start_offset..cursor).to_string();
cx.callback( cx.callback(
future, future,
@ -3960,7 +3959,7 @@ pub fn completion(cx: &mut Context) {
return; return;
} }
let mut items = match response { let items = match response {
Some(lsp::CompletionResponse::Array(items)) => items, Some(lsp::CompletionResponse::Array(items)) => items,
// TODO: do something with is_incomplete // TODO: do something with is_incomplete
Some(lsp::CompletionResponse::List(lsp::CompletionList { Some(lsp::CompletionResponse::List(lsp::CompletionList {
@ -3970,15 +3969,6 @@ pub fn completion(cx: &mut Context) {
None => Vec::new(), None => Vec::new(),
}; };
if !prefix.is_empty() {
items.retain(|item| {
item.filter_text
.as_ref()
.unwrap_or(&item.label)
.starts_with(&prefix)
});
}
if items.is_empty() { if items.is_empty() {
// editor.set_error("No completion available"); // editor.set_error("No completion available");
return; return;