kc/helix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

minor: Setup default keymap directly in xtask docgen

Browse source 
Instantiating EditorView is a lot of machinery which is unnecessary:
the default keymap is exposed through the `default` function in the
keymap module.
This commit is contained in:
Michael Davis 2024-12-28 21:40:57 -05:00
parent 127567df8e
commit 073efe48f9
No known key found for this signature in database
2 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
helix-term/src/ui/editor.rs
View file

@ -57,12 +57,6 @@ pub enum InsertEvent {
RequestCompletion, RequestCompletion,
} }
impl Default for EditorView {
fn default() -> Self {
Self::new(Keymaps::default())
}
}
impl EditorView { impl EditorView {
pub fn new(keymaps: Keymaps) -> Self { pub fn new(keymaps: Keymaps) -> Self {
Self { Self {

3
xtask/src/docgen.rs
View file

@ -5,7 +5,6 @@ use crate::DynError;
use helix_term::commands::MappableCommand; use helix_term::commands::MappableCommand;
use helix_term::commands::TYPABLE_COMMAND_LIST; use helix_term::commands::TYPABLE_COMMAND_LIST;
use helix_term::health::TsFeature; use helix_term::health::TsFeature;
use helix_term::ui::EditorView;
use helix_view::document::Mode; use helix_view::document::Mode;
use std::collections::HashSet; use std::collections::HashSet;
@ -56,7 +55,7 @@ pub fn typable_commands() -> Result<String, DynError> {
pub fn static_commands() -> Result<String, DynError> { pub fn static_commands() -> Result<String, DynError> {
let mut md = String::new(); let mut md = String::new();
let keymap = EditorView::default().keymaps.map(); let keymap = helix_term::keymap::default();
let keymaps = [ let keymaps = [
("normal", keymap[&Mode::Normal].reverse_map()), ("normal", keymap[&Mode::Normal].reverse_map()),
("select", keymap[&Mode::Select].reverse_map()), ("select", keymap[&Mode::Select].reverse_map()),